Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a short contributing guide and scope #292

Merged
merged 3 commits into from
Oct 8, 2023

Conversation

milancurcic
Copy link
Member

Closes #289.

Don't merge before #291.

@milancurcic milancurcic added the documentation Improvements or additions to documentation label Oct 6, 2023
@milancurcic milancurcic requested a review from selipot October 6, 2023 19:44
@milancurcic milancurcic self-assigned this Oct 6, 2023
Copy link
Member

@selipot selipot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit with added links. Otherwise looks great.

@selipot
Copy link
Member

selipot commented Oct 7, 2023

With this newly defined scope, the wavelet module is out of scope ... except that it is used eventually for the inertial extraction functions to come. Not sure what we think about this.

@selipot selipot merged commit 152a2af into Cloud-Drift:main Oct 8, 2023
12 checks passed
philippemiron pushed a commit to philippemiron/clouddrift that referenced this pull request Nov 16, 2023
* Add a short contributing guide and scope

* Grammar

* added links and edit

---------

Co-authored-by: Shane Elipot <selipot@miami.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Scope and Contributing guidelines to the README
3 participants