-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RaggedArray.from_xarray()
#51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a test to check if the dimension names are not "traj" and "obs". Also, you can do from clouddrift import RaggedArray
directly because __init__.py
imports automatically the class in the dataformat.py
.
Actually, I have two more comments to discuss:
|
Thanks, Philippe. On the first point, yes, it would be more useful, but I chose to leave it alone for now because we're considering removing readers and writers for file formats (parquet and netcdf). The rationale is that the users will work with data in xarray or awkward, and they can read and write from and to files from those libraries. And similar for zarr. Most likely we'll just show the user how to do it from xarray. Less likely, you're right, it can be the same wrapper as from_netcdf. Another reason that it wouldn't be part of this PR is that I want to keep PRs small and focused (single feature). |
Thank you for the review! |
Closes #44