Merge pull request #8 from CloudCannon/fix/empty-image-src

Feat: empty image check
CloudCannon · Nov 12, 2024 · 40ce4b8 · 40ce4b8
2 parents 6a418eb + 3bd5c12
commit 40ce4b8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 14 deletions.
diff --git a/component-library/components/cards/cards.eleventy.liquid b/component-library/components/cards/cards.eleventy.liquid
@@ -3,7 +3,7 @@
         {% for card in cards %}
 		<div class="card">
 			<div class="media">
-				{% image card.media.url card.media.alt 500 %}
+				{% image card.media.image.url card.media.image.alt 500 %}
 			</div>
 			<div class="text">
 				<h3>

diff --git a/eleventy.config.js b/eleventy.config.js
@@ -10,7 +10,7 @@ module.exports = function(eleventyConfig) {
 	eleventyConfig.addPlugin(svgContents);
 
 	eleventyConfig.addShortcode("image", async function (src, alt, widths, sizes) {
-		if (src === undefined) {
+		if (src === undefined || src === null) {
 			return "";
 		}
 

diff --git a/src/index.html b/src/index.html
@@ -8,30 +8,24 @@
     cards:
       - media:
           image:
-            url: ''
-            alt: ''
-          url: /assets/campus.jpg
-          alt: Campus
+            url: /assets/campus.jpg
+            alt: Campus
         heading:
           text: Admissions
           url: '#'
         text: Learn more about the admissions process and how to apply.
       - media:
           image:
-            url: ''
-            alt: ''
-          url: /assets/lecture.jpg
-          alt: Lecture hall
+            url: /assets/lecture.jpg
+            alt: Lecture hall
         heading:
           text: Academics
           url: '#'
         text: Explore our academic programs and departments.
       - media:
           image:
-            url: ''
-            alt: ''
-          url: /assets/research.jpg
-          alt: Research lab
+            url: /assets/research.jpg
+            alt: Research lab
         heading:
           text: Research
           url: '#'