-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding flag to retain “index.html” in results URLs #233
Adding flag to retain “index.html” in results URLs #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, nice addition 🙂
### Keep Index URL | ||
|
||
```json | ||
{ | ||
"keepIndexUrl": true | ||
} | ||
``` | ||
|
||
Keeps `index.html` at the end of search result paths. For example, a file called "public/cat/index.html will have a search result url of `public/cat/index.html`. Defaults to `false`, stripping `index.html`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs should actually live in docs/config-options.md
— this page is for the browser-side config — but I can move them to the correct place after this is merged 🙂
No problem! When should I expect this to be in a release? |
A little while away from a stable release sorry @kenpetti-toasttab — I'm working on a raft of features that might push out to a full I am pushing out some prereleases while testing, though, so if you're running through npx you can use:
And that release contains this PR 🙂 (if you're using the binaries directly, you can find them here) These prereleases will eventually contain some breaking changes, but |
Great, thanks! Really happy so far, looking forward to seeing where this project goes! |
Change of plans! v0.12.0 is now out containing this feature 🙂 |
What
Why
My static site does not use “pretty” links. The current Pagefund behavior generates search result links that do not accurately link to my content. This change makes the links compatible.
Testing
I tested this manually locally. I also added a simple test for this flag. Any ideas for additional test cases are welcome.