Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: agent setting block is now fully optional #74

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

eddy-vera
Copy link
Contributor

@eddy-vera eddy-vera commented Nov 21, 2024

Description

Agent_setting block is optional as mentioned in the documentation, see https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/container_registry_task
It is not required when the agent_pool_name is set, see also hashicorp/terraform-provider-azurerm#28085

PR Checklist

  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have made corresponding changes to the documentation
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Change Log

Below please provide what should go into the changelog (if anything)

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking change (not backwards compatible with previous releases)

Related Issue(s)

Fixes #0000

@eddy-vera eddy-vera requested a review from a team as a code owner November 21, 2024 13:02
@dkooll dkooll changed the title fix: agent_setting block is now fully optional fix: agent setting block is now fully optional Nov 21, 2024
Copy link
Contributor

@dkooll dkooll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dkooll dkooll merged commit e3aee76 into main Nov 21, 2024
16 checks passed
@dkooll dkooll deleted the fix/task_cpu_setting branch November 21, 2024 13:09
@dkooll dkooll added the bug Something isn't working label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants