Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:185 #190

Merged
merged 4 commits into from
Sep 27, 2023
Merged

fix:185 #190

merged 4 commits into from
Sep 27, 2023

Conversation

limingoo
Copy link
Contributor

What is the purpose of the change

Related issues/PRs

Related issues: #185
Related pr:#185

Brief change log

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@@ -71,14 +71,15 @@ public Result createProject(String loginUser, String name, String desc) {
}

@Override
public Result updateProject(Integer projectId, String name, String desc) {
public Result updateProject(Integer projectId, String name, String image, String desc) {
Project newProject = projectMapper.selectById(projectId);
Result result = new Result();
if (newProject == null) {
putMsg(result, Status.PROJECT_NOT_EXISTS_ERROR);
return result;
}
newProject.setProjectName(name);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name != null
image != null
desc != null

@dlimeng dlimeng merged commit 5e4f316 into CloudOrc:dev Sep 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants