Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cookies #38

Merged
merged 7 commits into from
Apr 16, 2024
Merged

Support cookies #38

merged 7 commits into from
Apr 16, 2024

Conversation

Kas-tle
Copy link
Contributor

@Kas-tle Kas-tle commented Apr 4, 2024

Closes #37

Signed-off-by: Joshua Castle <26531652+Kas-tle@users.noreply.github.com>
Copy link
Contributor Author

@Kas-tle Kas-tle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Geyser and seems to connect fine. Verified cookie with wireshark. (Note if you try this yourself I also had to do a PR to wireshark to fix its handling of encryption being changed on the second reply, so see that PR here https://gitlab.com/wireshark/wireshark/-/merge_requests/15123 and build can be downloaded here https://github.com/Kas-tle/wireshark/actions/runs/8547183545)

@Alemiz112
Copy link
Member

Nice work! Was this tested against old versions of the game?

@Kas-tle
Copy link
Contributor Author

Kas-tle commented Apr 4, 2024

How far back would you need to know? I'll do my best to check as far as I can but unsure how far back the unofficial launcher can go.

@Alemiz112
Copy link
Member

I believe have support back to raknet version 8 or maybe 7. Let me know which versions you were able to test with. I should be able to test with the very old versions later.

Kas-tle added 2 commits April 4, 2024 20:02
- Add RAK_SEND_COOKIE to DefaultRakServerConfig#getOptions()
- Consolidate RakClientOfflineHandler#sendOpenConnectionRequest2 to single method
- Combine pendingConnections ExpiringMap

Signed-off-by: GitHub <noreply@github.com>
@Kas-tle
Copy link
Contributor Author

Kas-tle commented Apr 4, 2024

Will implement optimal SecureRandom later tonight.

Kas-tle added 2 commits April 4, 2024 15:49
Signed-off-by: Joshua Castle <26531652+Kas-tle@users.noreply.github.com>
Signed-off-by: Joshua Castle <26531652+Kas-tle@users.noreply.github.com>
Kas-tle added 2 commits April 4, 2024 19:41
Signed-off-by: Joshua Castle <26531652+Kas-tle@users.noreply.github.com>
Copy link
Member

@Alemiz112 Alemiz112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this feature!

@Alemiz112 Alemiz112 merged commit 730acaa into CloudburstMC:develop Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RakNet Security layer is not supported
3 participants