-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cookies #38
Support cookies #38
Conversation
Signed-off-by: Joshua Castle <26531652+Kas-tle@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Geyser and seems to connect fine. Verified cookie with wireshark. (Note if you try this yourself I also had to do a PR to wireshark to fix its handling of encryption being changed on the second reply, so see that PR here https://gitlab.com/wireshark/wireshark/-/merge_requests/15123 and build can be downloaded here https://github.com/Kas-tle/wireshark/actions/runs/8547183545)
Nice work! Was this tested against old versions of the game? |
How far back would you need to know? I'll do my best to check as far as I can but unsure how far back the unofficial launcher can go. |
I believe have support back to raknet version 8 or maybe 7. Let me know which versions you were able to test with. I should be able to test with the very old versions later. |
...port-raknet/src/main/java/org/cloudburstmc/netty/channel/raknet/config/RakChannelOption.java
Show resolved
Hide resolved
...rc/main/java/org/cloudburstmc/netty/handler/codec/raknet/client/RakClientOfflineHandler.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/cloudburstmc/netty/handler/codec/raknet/server/RakServerOfflineHandler.java
Show resolved
Hide resolved
- Add RAK_SEND_COOKIE to DefaultRakServerConfig#getOptions() - Consolidate RakClientOfflineHandler#sendOpenConnectionRequest2 to single method - Combine pendingConnections ExpiringMap Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Will implement optimal SecureRandom later tonight. |
Signed-off-by: Joshua Castle <26531652+Kas-tle@users.noreply.github.com>
Signed-off-by: Joshua Castle <26531652+Kas-tle@users.noreply.github.com>
transport-raknet/src/main/java/org/cloudburstmc/netty/util/SecureAlgorithmProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Joshua Castle <26531652+Kas-tle@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this feature!
Closes #37