Fix Issues with Offline State #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the security state not being updated. Some servers (e.g. Enchanted Dragons) send a cookie in their first
Open Connection Reply 1, but later send anotherOpen Connection Reply 1that omits the cookie. In such a case, we should also omit the cookie from our subsequentOpen Connection Request 2responses.Secondly,
RakClientOfflineHandlercurrently re-sends eitherOpen Connection Request 1orOpen Connection Request 2depending on the handshake state. The Vanilla client, however, will only sendOpen Connection Request 1as a retry.Open Request 2is only sent as a direct response toOpen Connection Reply 1. This PR brings the client inline with this behavior in compatibility mode.