Fixed that providerClass in BaseFullChunk can be null. #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetteriM1
approved these changes
Aug 26, 2021
wode490390
pushed a commit
to NetEasePE/Nukkit
that referenced
this pull request
Dec 10, 2021
(cherry picked from commit c29dbf4)
wode490390
pushed a commit
to NetEasePE/Nukkit
that referenced
this pull request
Dec 26, 2021
(cherry picked from commit c29dbf4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix that the providerClass can be null in BaseFullChunk. Reason for that can be that you create a chunk from binary:
https://github.com/CloudburstMC/Nukkit/blob/master/src/main/java/cn/nukkit/level/format/anvil/Chunk.java#L222
In this case the LevelProvider will be set later if it's null, but providerClass stays null, this will cause some NPE's e.g. if you place blocks in this chunk.