Skip to content

Commit

Permalink
Remove SIGCHLD handler
Browse files Browse the repository at this point in the history
SIG_DFL on SIGCHLD prevents proper functioning of pclose, which the new version of the pasting functionality requires.

Closes #385

Ref: https://stackoverflow.com/questions/54189212/popen-returns-1-unexpectedly
  • Loading branch information
ndren authored and Cloudef committed Mar 9, 2024
1 parent fab01c9 commit 9a7b736
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions client/bemenu-run.c
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#include <signal.h>
#include <unistd.h>
#include <dirent.h>
#include <assert.h>
Expand Down Expand Up @@ -166,14 +165,6 @@ item_cb(const struct client *client, struct bm_item *item)
int
main(int argc, char **argv)
{
struct sigaction action = {
.sa_handler = SIG_DFL,
.sa_flags = SA_NOCLDWAIT
};

// do not care about childs
sigaction(SIGCHLD, &action, NULL);

if (!bm_init())
return EXIT_FAILURE;

Expand Down

0 comments on commit 9a7b736

Please sign in to comment.