Email confirmed test #17

DmytroBaziuk · 2017-04-24T20:24:55Z

Я сделаль)

…gbranch

dee-kryvenko · 2017-05-05T12:02:50Z

app/models/user.js

@@ -10,21 +10,23 @@ module.exports = function (modelHelpers, connection, mongoose) {
        email: {type: String, required: true},
        name: {type: String, required: true},
        avatar: String,
-        roles: [{type: mongoose.Schema.Types.ObjectId, ref: 'UserRole'}]
+        roles: [{type: mongoose.Schema.Types.ObjectId, ref: 'UserRole'}],
+        emailConfirmed : {type: boolean}


{type: boolean, default: false}

dee-kryvenko · 2017-05-05T12:03:22Z

app/models/user.js

    });

    userSchema.methods.toString = function () {
        return this.username;
    };

-    userSchema.statics.generateNew = function (username, password, email, name, avatar, defaultRole) {
+    userSchema.statics.generateNew = function (username, password, email, name, avatar, defaultRole,) {


redundant , at the end

dee-kryvenko · 2017-05-05T12:04:19Z

unit-tests/models/model_entities.spec.js

@@ -126,6 +126,7 @@ describe('The entity', function() {
                email: {type: String, required: true},
                name: {type: String, required: true},
                avatar: String,
+                emailConfirmed : {type: boolean, required: true},


Should be same as above {type: boolean, default: false}

dee-kryvenko · 2017-05-05T12:04:46Z

unit-tests/models/model_entities.spec.js

@@ -143,6 +144,7 @@ describe('The entity', function() {
                email: 'test email',
                name: 'test name',
                avatar: 'test avatar',
+                emailConfirmed: 'test emailConfirmed',


emailConfirmed: false,

dee-kryvenko · 2017-05-05T12:05:42Z

app/config/passport.js

@@ -12,7 +12,8 @@ module.exports = function (passport, passportHelpers, models, moment, BasicStrat
        function (username, password, done) {
            User.findOne({
                username: username,
-                password: password
+                password: password,
+                emailConfirmed: true


For now, as we are not ready yet to send actual mails and validating them, let's allow unconfirmed mails to login. Hence it would be emailConfirmed: false

Dbaziuk added 4 commits April 12, 2017 18:32

created user flag option

f67cefa

Merge branch 'master' of github.com:CloudletLabs/clh-web-api into Fla…

6232043

…gbranch

emailconfirmation added

08b1fac

Test for EmailConfirmed from Me

bbf804f

DmytroBaziuk requested a review from dee-kryvenko April 24, 2017 20:25

dee-kryvenko suggested changes May 5, 2017

View reviewed changes

Test for EmailConfirmed from Me

bd65f2e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Email confirmed test #17

Email confirmed test #17

DmytroBaziuk commented Apr 24, 2017

dee-kryvenko May 5, 2017

DmytroBaziuk May 10, 2017

dee-kryvenko May 5, 2017

DmytroBaziuk May 10, 2017

dee-kryvenko May 5, 2017

DmytroBaziuk May 10, 2017

dee-kryvenko May 5, 2017

DmytroBaziuk May 10, 2017

dee-kryvenko May 5, 2017

DmytroBaziuk May 10, 2017

Email confirmed test #17

Are you sure you want to change the base?

Email confirmed test #17

Conversation

DmytroBaziuk commented Apr 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment