88x31 banner scrapper #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikhil25803 could you please take a look? <3 |
nikhil25803
requested changes
Oct 5, 2023
There was a problem hiding this comment.
This still needs a few changes
- Add the
__init__.pyfile in the folder so that it can be imported. - Remove all the print statements, keep docstrings only.
- Include your method in the
dev-documentation. mdfile.
Do let me know if you are done with these changes. Also, raise an issue first next time before starting work on any module :))
|
Will do, it's my first time working on a Library so I got to learn a lot!! |
|
@nikhil25803 g2g? |
nikhil25803
requested changes
Oct 5, 2023
Co-Authored-By: rudy3 <46790388+rudy3333@users.noreply.github.com>
nikhil25803
added
hacktoberfest
|
Great work @rudy3333 !!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a scrapper for https://cyber.dabamos.de/88x31/index.html