[FLOC-4245] Factor out plugin loading. #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Potentially add a bit more context on either the PR comment or the JIRA ticket. I happen to know the motivation, but it'd be nice to be able to know that just by reading the PR description. |
| @@ -552,8 +404,6 @@ def get_api(backend, api_args, reactor, cluster_id): | |||
|
|
|||
| class AgentService(PClass): | |||
| """ | |||
| :ivar backends: ``BackendDescription`` instances describing how to use each | |||
There was a problem hiding this comment.
I think this still needs documentation, just different documentation.
There was a problem hiding this comment.
The original refactoring didn't have an attribute here. I forgot to add back the documentation when I added it back.
|
Couple nits, but in general looks great. Nice to get this code refactored to a location that it can be re-used by other parts of the flocker codebase. |
tomprince
added a commit
that referenced
this pull request
Mar 3, 2016
[FLOC-4245] Factor out plugin loading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://clusterhq.atlassian.net/browse/FLOC-4245