-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new mongo image for tutorial - fixes 383 #476
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bea6bc4
modified: Vagrantfile
dwgebler e59daf3
reference clusterhq/mongodb image in place of old mongodb-tutorial image
dwgebler 948898c
modified: tutorial/Vagrantfile
dwgebler b41d33e
Merge remote-tracking branch 'refs/remotes/origin/master' into mongo-…
itamarst 30550cc
We don't need vagrant-cachier any more.
itamarst e1fd0a5
change references to dockerfile/mongodb image to clusterhq/mongodb
dwgebler f596d29
modified: volumes.rst
dwgebler 01e9180
Merge branch 'mongo-tutorial-vagrantfile-383' of github.com:ClusterHQ…
dwgebler 9915ba6
Update exposing-ports.rst
dwgebler 3a6a006
Update exposing-ports.rst
dwgebler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
"version": 1 | ||
"applications": | ||
"mongodb-example": | ||
"image": "mongodb-tutorial" | ||
"image": "clusterhq/mongodb" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
"version": 1 | ||
"applications": | ||
"mongodb-port-example": | ||
"image": "mongodb-tutorial" | ||
"image": "clusterhq/mongodb" | ||
"ports": | ||
- "internal": 27017 | ||
"external": 27017 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
"version": 1 | ||
"applications": | ||
"mongodb-volume-example": | ||
"image": "mongodb-tutorial" | ||
"image": "clusterhq/mongodb" | ||
"ports": | ||
- "internal": 27017 | ||
"external": 27017 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You also need to change the mount point to be |
||
"volume": | ||
# The location within the container where the data volume will be | ||
# mounted: | ||
"mountpoint": "/data" | ||
"mountpoint": "/data/db" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest simplifying this to just a
docker pull
given the image is so small.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And then removing references to
vagrant-cachier
- less fragility, less steps.