Dev: ra: Refine RAInfo.params interface to exclude some completion re…

…sults

crmsh/ra.py

@@ -377,20 +377,14 @@ def mk_ra_node(self):
         self.broken_ra = False
         return self.ra_elem
 
-    def params(self, completion=False):
+    def params(self):
         '''
         Construct a dict of dicts: parameters are keys and
         dictionary of attributes/values are values. Cached too.
 
         completion:
         If true, filter some (advanced) parameters out.
         '''
-        if completion:
-            if self.mk_ra_node() is None:
-                return None
-            return [c.get("name")
-                    for c in self.ra_elem.xpath("//parameters/parameter")
-                    if c.get("name") and c.get("name") not in self.excluded_from_completion]
         ident = "ra_params-%s" % self
         if cache.is_cached(ident):
             return cache.retrieve(ident)
@@ -399,7 +393,7 @@ def params(self, completion=False):
         d = {}
         for c in self.ra_elem.xpath("//parameters/parameter"):
             name = c.get("name")
-            if not name:
+            if not name or name in self.excluded_from_completion:
                 continue
             required = c.get("required") if not (c.get("deprecated") or c.get("obsoletes")) else "0"
             unique = c.get("unique")

crmsh/ui_configure.py

@@ -234,7 +234,7 @@ def _prim_params_completer(agent, args):
     if command.sort_completion_inst is not None:
         # Set the value to 0 to use the costum sort order
         command.sort_completion_inst.value = 0
-    return utils.filter_keys(agent.params(completion=True), args)
+    return utils.filter_keys(agent.params(), args)
 
 
 def _prim_meta_completer(agent, args):