[crmsh-4.6] Fix: report: Unable to gather log files that are in the syslog format (bsc#1218491) #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangxin1300
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## crmsh-4.6 #1295 +/- ##
=============================================
+ Coverage 52.65% 52.66% +0.01%
=============================================
Files 83 79 -4
Lines 25018 23938 -1080
=============================================
- Hits 13172 12608 -564
+ Misses 11846 11330 -516 ☔ View full report in Codecov by Sentry. |
liangxin1300
force-pushed
the
20240103_crm_report_behave
branch
7 times, most recently
from
aa436ec to
79dc1e5
Compare
liangxin1300
force-pushed
the
20240103_crm_report_behave
branch
3 times, most recently
from
688d0ed to
4ce3de4
Compare
… (bsc#1218491) Logs in syslog format lack year information, making it challenging to determine the year a line was recorded. Therefore, when encountering a future timestamp, we must estimate the year
liangxin1300
force-pushed
the
20240103_crm_report_behave
branch
4 times, most recently
from
ad1586e to
509bd49
Compare
This is because code that uses multiprocessing was not factored into the test coverage calculation
liangxin1300
force-pushed
the
20240103_crm_report_behave
branch
from
509bd49 to
5f1fb4d
Compare
nicholasyang2022
approved these changes
Jan 9, 2024
liangxin1300
added a commit
to liangxin1300/crmsh
that referenced
this pull request
Mar 19, 2024
So that the crmsh.log can include the year information. See also: ClusterLabs#1295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs in syslog format lack year information, making it challenging to determine the year a line was recorded. Therefore, when encountering a future timestamp, we must estimate the year