Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crmsh-4.6] Fix: qnetd fails to start when TLS is disabled (bsc#1227649) #1492

Merged
merged 8 commits into from
Jul 18, 2024
Merged

[crmsh-4.6] Fix: qnetd fails to start when TLS is disabled (bsc#1227649) #1492

merged 8 commits into from
Jul 18, 2024

Conversation

nicholasyang2022
Copy link
Collaborator

@nicholasyang2022
Fix: qdevice: TLS certs should always be generated for qnetd (bsc#122…
27ad10c 
…7649)

As qnetd is configured (by default) to accept incoming TLS connections.
@nicholasyang2022
Fix: bootstrap: refine the wording in the question asking TLS config …
8e4c2c1 
…for qdevice (bsc#1227649)

This question controls only the configuration of the client side.
@nicholasyang2022
Fix: qdevice: config "tls" should accept value "required" (bsc#1227649)
48a8d39
@nicholasyang2022
Dev: unittest: adjust unit tests for previous commits
081e8f5
@nicholasyang2022
fix a typo
4627c90
@nicholasyang2022
Dev: behave: adjust functional tests for previous commits
628600a
@nicholasyang2022
Dev: prun: add more possible libexec PATH for sftp-server
e69ffab
@nicholasyang2022
Dev: qdevice: numbers automatically the steps to generate client certs
764ed2f 
This avoids hardcoding step numbers in code and comments and provides
flexibility for future changes.
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (c51f137) to head (764ed2f).

Additional details and impacted files
Flag Coverage Δ
integration 53.22% <97.56%> (-0.07%) ⬇️
unit 49.87% <95.23%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
crmsh/bootstrap.py 84.64% <100.00%> (ø)
crmsh/prun/prun.py 93.87% <100.00%> (+0.04%) ⬆️
crmsh/qdevice.py 98.77% <100.00%> (-0.05%) ⬇️
crmsh/ui_cluster.py 77.55% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholasyang2022 nicholasyang2022 marked this pull request as ready for review July 18, 2024 10:03
@liangxin1300 liangxin1300 merged commit c5fa894 into ClusterLabs:crmsh-4.6 Jul 18, 2024
31 checks passed
@nicholasyang2022 nicholasyang2022 deleted the bsc_1227649_20240716_4.6 branch July 24, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangxin1300 liangxin1300 liangxin1300 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasyang2022 @liangxin1300