[crmsh-4.6] Fix: Add a new option 'has_fa_advised_op' (bsc#1228858) #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This option is used to automatically add the advised operation values for fencing agents. Default value is 'no', which means doesn't add the advised operation values for fencing agents.
Add a specific flag 'auto_add_time_units', avoid mixing with the flag of auto add advised operation values for RA.
Which is used to control the advised operations for resource agents, to distinct from the 'fa_advised_op_values' which is used to control the advised operations for fence agents. And rename relative internal variables.
…r origin functional tests To avoid more changes for the expected test results
liangxin1300
force-pushed
the
20240829_bsc_1228858_fa_no_advised_op_crmsh46
branch
from
814167a to
c92adee
Compare
zzhou1
approved these changes
Sep 2, 2024
From 'ra_advised_op_values' to 'has_ra_advised_op'; From 'fa_advised_op_values' to 'has_fa_advised_op'
liangxin1300
changed the title
liangxin1300
added a commit
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is used to automatically add the advised operation values
for fencing agents. Default value is 'no', which means doesn't add the
advised operation values for fencing agents.
Other changes: