[crmsh-4.6] Fix: report.utils: Fix the performance issue (bsc#1232821) #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
liangxin1300
force-pushed
the
20241105_bsc_1232821
branch
2 times, most recently
from
368d969 to
13b4f9e
Compare
liangxin1300
changed the title
liangxin1300
force-pushed
the
20241105_bsc_1232821
branch
from
13b4f9e to
58ae942
Compare
liangxin1300
changed the title
liangxin1300
force-pushed
the
20241105_bsc_1232821
branch
from
19947b6 to
11795f2
Compare
crmsh/report/constants.py
Outdated
| @@ -3,7 +3,7 @@ | |||
| BIN_CRM = "/usr/sbin/crm" | |||
| BIN_COLLECTOR = f"{BIN_CRM} report __collector" | |||
| COMPRESS_DATA_FLAG = "COMPRESS CRM_REPORT DATA:::" | |||
| LOG_PATTERNS = "CRIT: ERROR: error: warning: crit:" | |||
| LOG_PATTERNS = "CRIT: ERROR: WARNING: crit: error: warning:" | |||
There was a problem hiding this comment.
Instead of defining these patterns as space-separated string, we can define it directly as a list of strings.
The function `extract_critical_log` can be very slow when processing large log files. The main issue is the inefficiency of the regular expression, which combines multiple wildcards (.*) with alternation (|), leading to excessive backtracking. Additionally, the function reads the entire file into memory, which is not optimal for large files. To improve performance, it is better to use `grep` with the -F option to search for fixed strings.
…dify time No need to check the rest of the files if the from time is greater than the modify time of the file.
liangxin1300
force-pushed
the
20241105_bsc_1232821
branch
from
11795f2 to
5ee01e1
Compare
nicholasyang2022
approved these changes
Nov 8, 2024
liangxin1300
added a commit
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
extract_critical_logcan be very slow when processing large log files. The main issue is the inefficiency of the regular expression, which combines multiple wildcards (.*) with alternation (|), leading to excessive backtracking. Additionally, the function reads the entire file into memory, which is not optimal for large files.To improve performance, it is better to use
grepwith the -F option to search for fixed strings.And for a sequence of archived log files, check the modify time. No need to check the rest of the files if the from time is greater than the modify time of the file.