Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make minor changes based on Pacemaker-3.0's change log #1660

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Jan 9, 2025

Changed:

  • Dev: bootstrap: Drop 'record-pending' operation option

  • Dev: utils: Make change since 'crmd-transition-delay' already renamed to 'transition-delay'

  • Dev: constants: Drop deprecated "crmd-integration-timeout" and "crmd-finalization-timeout"

  • Dev: crash_test: Drop deprecated 'poweroff' value of 'stonith-action' option

  • Dev: Remove deprecated cibadmin --local option

  • Dev: Drop unsupported 'moon' in date_spec

  • Dev: constants: Drop deprecated 'restart-type' resource option

  • Dev: Improve options of 'crm status' command

    • Reduce duplicated options definition
    • Drop deprecated '-s/--simple-status' option
  • Dev: Drop support for name with id-ref attribute

@liangxin1300 liangxin1300 changed the title 20250109 pacemaker 3.0 changes Make change based on Pacemaker-3.0's change log Jan 9, 2025
@liangxin1300 liangxin1300 force-pushed the 20250109_pacemaker_3.0_changes branch 2 times, most recently from 2e14481 to 19b75ea Compare January 9, 2025 05:56
@liangxin1300 liangxin1300 changed the title Make change based on Pacemaker-3.0's change log Make minor changes based on Pacemaker-3.0's change log Jan 9, 2025
@liangxin1300 liangxin1300 force-pushed the 20250109_pacemaker_3.0_changes branch from 6cf465a to a314ccc Compare January 19, 2025 08:20
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.74%. Comparing base (155bd2c) to head (5c84927).

Files with missing lines Patch % Lines
crmsh/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 53.55% <61.53%> (+<0.01%) ⬆️
unit 53.10% <69.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/bootstrap.py 88.11% <ø> (ø)
crmsh/cmd_status.py 77.41% <100.00%> (ø)
crmsh/completers.py 56.81% <ø> (-0.96%) ⬇️
crmsh/constants.py 100.00% <ø> (ø)
crmsh/crash_test/utils.py 90.05% <100.00%> (+0.05%) ⬆️
crmsh/parse.py 81.59% <100.00%> (ø)
crmsh/report/collect.py 97.91% <ø> (ø)
crmsh/ui_resource.py 72.69% <100.00%> (ø)
crmsh/ui_root.py 82.95% <100.00%> (ø)
crmsh/xmlutil.py 69.25% <100.00%> (-0.07%) ⬇️
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 force-pushed the 20250109_pacemaker_3.0_changes branch from 71397e3 to f23740a Compare January 19, 2025 09:28
@liangxin1300 liangxin1300 marked this pull request as ready for review January 19, 2025 13:14
@liangxin1300 liangxin1300 force-pushed the 20250109_pacemaker_3.0_changes branch from 7548d9b to 1382a2b Compare January 20, 2025 07:21
@zzhou1
Copy link
Contributor

zzhou1 commented Jan 20, 2025

Do you want this PR scope in

@liangxin1300 liangxin1300 force-pushed the 20250109_pacemaker_3.0_changes branch from 1382a2b to f733088 Compare January 26, 2025 07:29
@liangxin1300
Copy link
Collaborator Author

Do you want this PR scope in

Done

@liangxin1300 liangxin1300 force-pushed the 20250109_pacemaker_3.0_changes branch from f733088 to 5c84927 Compare January 26, 2025 07:55
@liangxin1300
Copy link
Collaborator Author

liangxin1300 commented Jan 27, 2025

Thinking: Considering the user might have a chance to downgrade the schema, is this PR suitable to drop these codes?

Or, make a schema-version-checker to drop these functionalities only when using pacemaker-4.0+?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants