Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: bootstrap: Check if core packages like corosync/pacemaker are installed #1675

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liangxin1300
Copy link
Collaborator

Fix #1674

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.74%. Comparing base (155bd2c) to head (c3104db).

Files with missing lines Patch % Lines
crmsh/bootstrap.py 80.00% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 53.54% <85.71%> (-0.01%) ⬇️
unit 53.10% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/ui_cluster.py 75.14% <100.00%> (ø)
crmsh/bootstrap.py 88.08% <80.00%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crmsh should exit earlier when pacemaker/corosync not available
1 participant