Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: cinconfig: enable "related:" prefix to show the objects by given ra type #978

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Jun 2, 2022

crm(live/tbw-1)configure# show related:Dummy
primitive d1 Dummy
primitive d2 Dummy
primitive d3 ocf:pacemaker:Dummy
crm(live/tbw-1)configure# show related:IPaddr2
primitive vip1 IPaddr2 \
        params ip=10.10.10.123 \
        op monitor interval=10s
primitive vip2 IPaddr2 \
        params ip=10.10.10.124 \
        op monitor interval=10s
crm(live/tbw-1)configure# show related:ocf:heartbeat:Dummy
primitive d1 Dummy
primitive d2 Dummy

Should be part of requirements from #698 and #819

Others:

  • Complete the help info

@liangxin1300 liangxin1300 requested a review from zzhou1 June 2, 2022 03:08
@liangxin1300
Copy link
Collaborator Author

Hi @klaernie, @zzhou1, @sjvudp

Could you please take a look at this?

Thanks!

@klaernie
Copy link

That looks cool! Can't wait to see this in production! Thanks, @liangxin1300 !

@zzhou1
Copy link
Contributor

zzhou1 commented Jun 10, 2022

Hi @klaernie, @zzhou1, @sjvudp

Could you please take a look at this?

Yes, I like this functionality in general!

After revisiting this, I have some impression for the better user experience, if possible:

a) first of all, try to avoid adding yet another "ra_type" to the user interface. crmsh user interface is big enough already, and maybe even too big to be consumed by the end user efficiently.

b) with that, I propose to extend this functionality to the existing 'related' prefix,
ie, crm configure show related:Dummy

@liangxin1300 liangxin1300 changed the title Dev: cinconfig: add ra_type: prefix to show the objects by given ra type Dev: cinconfig: enable "related:" prefix to show the objects by given ra type Jun 14, 2022
@liangxin1300
Copy link
Collaborator Author

Hi @klaernie, @zzhou1, @sjvudp
Could you please take a look at this?

Yes, I like this functionality in general!

After revisiting this, I have some impression for the better user experience, if possible:

a) first of all, try to avoid adding yet another "ra_type" to the user interface. crmsh user interface is big enough already, and maybe even too big to be consumed by the end user efficiently.

b) with that, I propose to extend this functionality to the existing 'related' prefix, ie, crm configure show related:Dummy

Nice suggestion
Changed

Thanks!

@liangxin1300 liangxin1300 merged commit f76fee2 into ClusterLabs:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants