Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ping resource: Use fping6 for IPv6 hosts #972

Merged
merged 1 commit into from
Apr 20, 2016

Conversation

Werkov
Copy link
Contributor

@Werkov Werkov commented Apr 20, 2016

ping RA doesn't work correctly with IPv6 addresses, it should use fping6instead of fping. I've implemented very simple address parsing that is not as precise as that in resource agents, however, it makes do only with shell builtins.

Cc: @gao-yan

@kgaillot
Copy link
Contributor

It's better than what we had, anyway.

We should probably do the same for ping/ping6.

A more general solution might be to add a host6_list parameter, or to dynamically separate host_list into "words with :" and "words without :".

@kgaillot kgaillot merged commit de4bcaf into ClusterLabs:master Apr 20, 2016
@jnpkrn
Copy link
Contributor

jnpkrn commented Apr 21, 2016

To be noted that ping utility from iputils (finally!) converged on a single CLI interface:
iputils/iputils#5

We can only hope fping will follow this example for the overall sanity.

@jnpkrn
Copy link
Contributor

jnpkrn commented Apr 21, 2016

...see also: schweikert/fping#80

For the record, Fedora brings transparent IPv6 support in "ping"
command as of release 24:
https://fedoraproject.org/wiki/Changes/PingIpv6#Ping_IPv6

@kgaillot
Copy link
Contributor

Those are all good news, though they make it a bit more complicated for us, since we'll have to figure out what version is installed on the local system and call it appropriately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants