ProcessWapper.StartWithEvents now supports dotnet 8. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actbit
changed the title
|
I closed the pull request by mistake. This pull request is valid. |
|
It doesn't actually open the Minecraft window? On my Windows PC, the Minecraft window opens fine, even on .net 8.0. |
…ent does not open on .NET .8.0. .NET 8 breaking change: ProcessStartInfo.WindowsStyle honored when UseShellExecute is false https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/8.0/processstartinfo-windowstyle
AlphaBs
force-pushed
the
feature-support-dotnet-8
branch
from
2f026f7 to
daba775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a breaking change related to Process in dotnet 8, Minecraft will not start correctly when using the ProcessWapper.StartWithEvents method.
More information about this breaking change can be found here.
Until now, if StartInfo.ShellUse was set to false, WindowStyle.Normal was always used regardless of the WindowStyle setting, but from dotnet 8, the WindowStyle setting is applied even if it is false.
In ProcessWapper.StartWithEvents, WindowStyle is specified as Hidden, which means the Minecraft window is not displayed.
For this reason, WindowStyle has been changed to Normal.