Add modifications respecting comments (#7)

CmsHI · Apr 27, 2023 · c857a54 · c857a54
1 parent 948155f
commit c857a54
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 14 deletions.
diff --git a/RecoBTag/FeatureTools/plugins/ParticleTransformerAK4TagInfoProducer.cc b/RecoBTag/FeatureTools/plugins/ParticleTransformerAK4TagInfoProducer.cc
@@ -60,7 +60,7 @@ class HistogramProbabilityEstimator;
 class ParticleTransformerAK4TagInfoProducer : public edm::stream::EDProducer<> {
 public:
   explicit ParticleTransformerAK4TagInfoProducer(const edm::ParameterSet&);
-  ~ParticleTransformerAK4TagInfoProducer() override;
+  ~ParticleTransformerAK4TagInfoProducer() override = default;
 
   static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);
 
@@ -77,21 +77,21 @@ class ParticleTransformerAK4TagInfoProducer : public edm::stream::EDProducer<> {
   const double min_candidate_pt_;
   const bool flip_;
 
-  edm::EDGetTokenT<edm::View<reco::Jet>> jet_token_;
-  edm::EDGetTokenT<VertexCollection> vtx_token_;
-  edm::EDGetTokenT<SVCollection> sv_token_;
+  const edm::EDGetTokenT<edm::View<reco::Jet>> jet_token_;
+  const edm::EDGetTokenT<VertexCollection> vtx_token_;
+  const edm::EDGetTokenT<SVCollection> sv_token_;
   edm::EDGetTokenT<edm::ValueMap<float>> puppi_value_map_token_;
   edm::EDGetTokenT<edm::ValueMap<int>> pvasq_value_map_token_;
   edm::EDGetTokenT<edm::Association<VertexCollection>> pvas_token_;
-  edm::EDGetTokenT<edm::View<reco::Candidate>> candidateToken_;
-  edm::ESGetToken<TransientTrackBuilder, TransientTrackRecord> track_builder_token_;
+  const edm::EDGetTokenT<edm::View<reco::Candidate>> candidateToken_;
+  const edm::ESGetToken<TransientTrackBuilder, TransientTrackRecord> track_builder_token_;
   bool use_puppi_value_map_;
   bool use_pvasq_value_map_;
 
-  bool fallback_puppi_weight_;
-  bool fallback_vertex_association_;
+  const bool fallback_puppi_weight_;
+  const bool fallback_vertex_association_;
 
-  bool is_weighted_jet_;
+  const bool is_weighted_jet_;
 
   const double min_jet_pt_;
   const double max_jet_eta_;
@@ -133,8 +133,6 @@ ParticleTransformerAK4TagInfoProducer::ParticleTransformerAK4TagInfoProducer(con
   }
 }
 
-ParticleTransformerAK4TagInfoProducer::~ParticleTransformerAK4TagInfoProducer() {}
-
 void ParticleTransformerAK4TagInfoProducer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
   // pfParticleTransformerAK4TagInfos
   edm::ParameterSetDescription desc;

diff --git a/RecoBTag/ONNXRuntime/plugins/ParticleTransformerAK4ONNXJetTagsProducer.cc b/RecoBTag/ONNXRuntime/plugins/ParticleTransformerAK4ONNXJetTagsProducer.cc
@@ -21,7 +21,7 @@ using namespace cms::Ort;
 class ParticleTransformerAK4ONNXJetTagsProducer : public edm::stream::EDProducer<edm::GlobalCache<ONNXRuntime>> {
 public:
   explicit ParticleTransformerAK4ONNXJetTagsProducer(const edm::ParameterSet&, const ONNXRuntime*);
-  ~ParticleTransformerAK4ONNXJetTagsProducer() override;
+  ~ParticleTransformerAK4ONNXJetTagsProducer() override = default;
 
   static void fillDescriptions(edm::ConfigurationDescriptions&);
 
@@ -78,8 +78,6 @@ ParticleTransformerAK4ONNXJetTagsProducer::ParticleTransformerAK4ONNXJetTagsProd
   }
 }
 
-ParticleTransformerAK4ONNXJetTagsProducer::~ParticleTransformerAK4ONNXJetTagsProducer() {}
-
 void ParticleTransformerAK4ONNXJetTagsProducer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
   // pfParticleTransformerAK4JetTags
   edm::ParameterSetDescription desc;