Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #401 - game rooms are misaligned #405

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Fixes #401 - game rooms are misaligned #405

merged 1 commit into from
Dec 5, 2022

Conversation

devo1929
Copy link
Contributor

@devo1929 devo1929 commented Dec 5, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Nightly build for this pull request:

  • artifacts.zip
    This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

Metadorius
Metadorius approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@Metadorius Metadorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am only not sure we should change default values. I don't recall the client having only 4 games per column, for instance.

@Metadorius
Copy link
Member

Wait I am stupid, you didn't change anything, nevermind

@Metadorius Metadorius merged commit 3afa773 into develop Dec 5, 2022
@devo1929 devo1929 deleted the b-401 branch December 5, 2022 10:47
SadPencil pushed a commit to SadPencil/xna-cncnet-client that referenced this pull request Oct 4, 2024
@devo1929 @SadPencil
Fixes CnCNet#401 - game rooms are misaligned (CnCNet#405)
901f8e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Metadorius Metadorius Metadorius approved these changes

@Rampastring Rampastring Awaiting requested review from Rampastring

@CCHyper CCHyper Awaiting requested review from CCHyper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devo1929 @Metadorius