-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation system config reading fix #476
Translation system config reading fix #476
Conversation
Nightly build for this pull request:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could you update to the newest develop (we switched back to net48 as the main target) and verify everything works under net48?
PR has been updated to the newest develop changes and tested. My custom TI client works fine. Documentation has been updated too. |
* Fix logic for using any number and letters after GameFile keys * Fix typo * Fix syntax error and add info to the docs * Apply suggestions from code review --------- Co-authored-by: Kerbiter <crabiter@vivaldi.net>
* Fix logic for using any number and letters after GameFile keys * Fix typo * Fix syntax error and add info to the docs * Apply suggestions from code review --------- Co-authored-by: Kerbiter <crabiter@vivaldi.net>
During the porting of the Twisted Insurrection russifier to the new client version, I was surprised that the key reading algorithm for copying the game files was hardcoded to the key number after
GameFile
. Thanks to Kerbiter, I was able to quickly find the place where those keys were read and processed. Now to make this feature work, you don't need to a specific number in keys. You can use any set of letters in the keys, as long as the keys starts withGameFile
.Example
[Translations]
section keys inClientDefinitions.ini
with old reading algorithm:Example
[Translations]
section keys inClientDefinitions.ini
with new reading algorithm: