Update XNALinkButton to support alternative URL on *nix #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belonit
force-pushed
the
feature-XNAExecuteButton
branch
from
9b370d3 to
ebe3d64
Compare
|
Nightly build for this pull request:
|
Belonit
force-pushed
the
feature-XNAExecuteButton
branch
from
ebe3d64 to
898c752
Compare
Belonit
changed the title
Belonit
force-pushed
the
feature-XNAExecuteButton
branch
from
898c752 to
fc35b66
Compare
Metadorius
requested changes
Aug 23, 2023
ClientGUI/XNALinkButton.cs
Outdated
Comment on lines
37
to
44
| if (UnixURL.Length != 0 && osVersion == OSVersion.UNIX) | ||
| { | ||
| ProcessLauncher.StartShellProcess(UnixURL); | ||
| } | ||
| else if (URL.Length != 0) | ||
| { | ||
| ProcessLauncher.StartShellProcess(URL); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (UnixURL.Length != 0 && osVersion == OSVersion.UNIX) | |
| { | |
| ProcessLauncher.StartShellProcess(UnixURL); | |
| } | |
| else if (URL.Length != 0) | |
| { | |
| ProcessLauncher.StartShellProcess(URL); | |
| } | |
| if (UnixURL.Length != 0 && osVersion == OSVersion.UNIX) | |
| ProcessLauncher.StartShellProcess(UnixURL); | |
| else if (URL.Length != 0) | |
| ProcessLauncher.StartShellProcess(URL); |
ClientGUI/XNALinkButton.cs
Outdated
| base.ParseControlINIAttribute(iniFile, key, value); | ||
| } | ||
|
|
||
| public override void OnLeftClick() | ||
| { | ||
| ProcessLauncher.StartShellProcess(URL); | ||
| OSVersion osVersion = ClientConfiguration.Instance.GetOperatingSystemVersion(); | ||
| string url = URL; |
There was a problem hiding this comment.
Suggested change
| string url = URL; |
Unused?
SadPencil
pushed a commit
to SadPencil/xna-cncnet-client
that referenced
this pull request
Oct 4, 2024
* Update XNALinkButton to support alternative URL on *nix * Make Kerbiter happier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.