Make CampaignID default to -1, with an optional override #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different parsing of duplicate entries in Battle.ini between the client and the game has led to the game crashing as the game sees duplicate entries as one entry, while the client sees them as separate entries. Separate entries are often used by modders to add separators to the mission list. The game is not known to really use the campaign ID for much (only the "do you need GDI/Nod/Firestorm CD" check is known), so setting it to -1 by default should do little harm. In case it does, there is now the possibility to manually override the campaign ID.
|
Nightly build for this pull request:
|
SadPencil
pushed a commit
to SadPencil/xna-cncnet-client
that referenced
this pull request
Oct 4, 2024
Different parsing of duplicate entries in Battle.ini between the client and the game has led to the game crashing as the game sees duplicate entries as one entry, while the client sees them as separate entries. Separate entries are often used by modders to add separators to the mission list. The game is not known to really use the campaign ID for much (only the "do you need GDI/Nod/Firestorm CD" check is known), so setting it to -1 by default should do little harm. In case it does, there is now the possibility to manually override the campaign ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different parsing of duplicate entries in Battle.ini between the client and the game (Tiberian Sun) has led to the game crashing as the game sees duplicate entries as one entry, while the client sees them as separate entries. Separate entries are often used by modders to add separators to the mission list.
The game is not known to really use the campaign ID for much (only the "do you need GDI/Nod/Firestorm CD" check is known), so setting it to
-1by default should do little harm. In case it does, there is now the possibility to manually override the campaign ID.-1is interpreted by the game asCAMPAIGN_NONE, which allows playing with any CD.This would also affect the game's "final campaign movie" logic (
FinalMovie=inBattle.ini), but as far as I know, no distribution of TS, vanilla or modded, makes use of that logic.