Close player extra option panel when leaving the lobby #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
|
Metadorius
approved these changes
Jul 9, 2024
SadPencil
added a commit
to SadPencil/xna-cncnet-client
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose a player turns on the extra option panel, leave the lobby, and then re-join a lobby, the extra option panel is still turned on, instead of the default panel that displays players with their factions, colors, and locations.
This current behavior might be non-straightforward to players -- panel that belongs to the parent should also be closed when the parent is closed. It might be better to auto close the extra option panel when user leaves the lobby.