Reduce default timeout to 10 seconds #575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web client was created by
new WebClient()
without assigning a timeout value. It seems that the default timeout value is undocumented, and the debugger told me the default value is 100000 ms (note: 100 seconds!) No wonder why some people with poor Internet condition complained about it takes too long to wait for their clients to initialize.This PR proposed the following changes:
TWebClient
introduced 8 years ago (here) sinceExtendedWebClient
was introduced 6 years ago (here)webClient.Proxy = null
introduced 8 years ago (here). Since now WebClients are initialized everywhere and no one explicitly clear the proxy setting like here, removing this statement will make the client behaves consistently -- leaving the proxy setting as system default.