-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notices for development builds #578
Conversation
Nightly build for this pull request:
|
Can you add option to disable text about development build in Doc example: [Settings]
ShowDevelopmentBuildWarnings=true ; boolean, activates warnings for non-release build of XNA Client.
; Please, make sure you are not publishing stable
; mod version with unstable development client build.
; Default value is `true`. |
@MahBoiDeveloper @Metadorius review comments addressed. Request re-reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please, add this key with default value and description into https://github.com/CnCNet/xna-cncnet-client/blob/develop/DXMainClient/Resources/ClientDefinitions.ini |
@SadPencil merge SadPencil#6 into this branch please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also needed to write different file metadata for non-release builds. From what I understand currently the metadata is not altered.
Don't know way to achieve this |
Co-authored-by: Kerbiter <crabiter@vivaldi.net>
I think he means completely wiping out something like |
This PR adds a "(Development Build)" suffix in title bar, as well as a log message, for non-release builds.
A build is considered as a release build if all of the following conditions are met:
Also, this PR adds "rc" as the tag suffix for non-release builds in master branch.
Also, this PR changes the version increment assumption: Patch version instead of Minor version will be increased even for develop branch. Since we aren't actually following SemVer.
Note: metadata of DLL/EXE files are not modified due to technical difficulties. Feel free to draft another PR if someone can achieve it.
SinceThisAssembly.Git
package is introduced, one needs to restart Visual Studio after a successful build for the first time. (We already have to do so since translation stub was introduced)