Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notices for development builds #578

Merged
merged 21 commits into from
Dec 6, 2024

Conversation

SadPencil
Copy link
Member

@SadPencil SadPencil commented Nov 5, 2024

This PR adds a "(Development Build)" suffix in title bar, as well as a log message, for non-release builds.

A build is considered as a release build if all of the following conditions are met:

  • The branch name is "master"
  • The commit has a tag with a correct version number recognized by GitVersion

Also, this PR adds "rc" as the tag suffix for non-release builds in master branch.

Also, this PR changes the version increment assumption: Patch version instead of Minor version will be increased even for develop branch. Since we aren't actually following SemVer.

Note: metadata of DLL/EXE files are not modified due to technical difficulties. Feel free to draft another PR if someone can achieve it.

图片

Since ThisAssembly.Git package is introduced, one needs to restart Visual Studio after a successful build for the first time. (We already have to do so since translation stub was introduced)

@SadPencil SadPencil added this to the 2.11.2.0 milestone Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

Nightly build for this pull request:

@SadPencil SadPencil changed the title Add notice for non-release builds Add notices for non-release builds Nov 5, 2024
@MahBoiDeveloper
Copy link
Contributor

Artifact for TSC works as intended.

image

@MahBoiDeveloper
Copy link
Contributor

Self-builded binaries also works.

image

DXMainClient/DXGUI/GameClass.cs Outdated Show resolved Hide resolved
@MahBoiDeveloper
Copy link
Contributor

Can you add option to disable text about development build in ClientDefinitions.ini? That would be helpful for modders.

Doc example:

[Settings]
ShowDevelopmentBuildWarnings=true ; boolean, activates warnings for non-release build of XNA Client. 
                                  ;          Please, make sure you are not publishing stable 
                                  ;          mod version with unstable development client build. 
                                  ;          Default value is `true`.

@SadPencil
Copy link
Member Author

SadPencil commented Nov 27, 2024

@MahBoiDeveloper @Metadorius review comments addressed. Request re-reviewing

@MahBoiDeveloper
Copy link
Contributor

All text are translatable.

Char warning message:
image

Title:
image

INI key works as intended:
image

Copy link
Contributor

@MahBoiDeveloper MahBoiDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MahBoiDeveloper
Copy link
Contributor

Please, add this key with default value and description into https://github.com/CnCNet/xna-cncnet-client/blob/develop/DXMainClient/Resources/ClientDefinitions.ini

@MahBoiDeveloper
Copy link
Contributor

Please, add this key with default value and description into https://github.com/CnCNet/xna-cncnet-client/blob/develop/DXMainClient/Resources/ClientDefinitions.ini

@SadPencil merge SadPencil#6 into this branch please.

Copy link
Member

@Metadorius Metadorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also needed to write different file metadata for non-release builds. From what I understand currently the metadata is not altered.

DXMainClient/DXGUI/GameClass.cs Outdated Show resolved Hide resolved
@SadPencil
Copy link
Member Author

It's also needed to write different file metadata for non-release builds. From what I understand currently the metadata is not altered.

Don't know way to achieve this

SadPencil and others added 2 commits December 4, 2024 05:17
@MahBoiDeveloper
Copy link
Contributor

It's also needed to write different file metadata for non-release builds. From what I understand currently the metadata is not altered.

Don't know way to achieve this

Isn't already done?
image

@SadPencil
Copy link
Member Author

SadPencil commented Dec 4, 2024

It's also needed to write different file metadata for non-release builds. From what I understand currently the metadata is not altered.

Don't know way to achieve this

Isn't already done? image

I think he means completely wiping out something like 2.11.0. Note that in some cases, we could get a version number like 2.12.0 which is misleading, e.g., #568

@Metadorius
Copy link
Member

Eh that works too I guess. I would have preferred complete wipe of course. Maybe @frg2089 or @devo1929 could help

@SadPencil
Copy link
Member Author

SadPencil commented Dec 5, 2024

图片
What happened? It lasts for hours

@SadPencil SadPencil changed the title Add notices for non-release builds Add notices for development builds Dec 6, 2024
@SadPencil SadPencil merged commit 248a551 into CnCNet:develop Dec 6, 2024
3 checks passed
@SadPencil SadPencil deleted the feat-non-release-notice branch December 8, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants