Randomize all maps when there is only one player #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When playerCount = 1, will get all maps, not only maps with maxplayers = 2
SadPencil
reviewed
Nov 25, 2024
SadPencil
changed the title
|
Nightly build for this pull request:
|
SadPencil
requested changes
Nov 27, 2024
|
@Flactine This is a reminder that please address the review comment since we want to merge this PR. |
You need to address the review comment, which means you need to pushing more commits so that your codes does not violate the requirements. It's not hitting the "Resolve conversation" button -- it just sent the information that you have addressed the comment, rather than let GitHub automatically solve it. |
Add a line break after }
SadPencil
changed the title
|
@Flactine After you have addressed all concerns, please hit each "Resolve conversation" button and then re-request reviews. See the screenshot below.
|
SadPencil
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the number of players is 1, the random map will be assigned to any map, regardless of the max players of the map.
Used to randomly check maps.