Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L10N for GameCollections.cs #586

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

Flactine
Copy link
Contributor

No description provided.

Copy link

Nightly build for this pull request:

@SadPencil SadPencil added this to the 2.11.2.0 milestone Nov 27, 2024
@Metadorius Metadorius merged commit 0ef3302 into CnCNet:develop Dec 1, 2024
3 checks passed
@enderseven1
Copy link

I have translated these names. But i set the L10N in a function names GetUIName(?) you can see my client code. Because some strange bug maybe happens if you set L10N at that UIName="".

@MahBoiDeveloper
Copy link
Contributor

MahBoiDeveloper commented Dec 1, 2024

I have translated these names. But i set the L10N in a function names GetUIName(?) you can see my client code. Because some strange bug maybe happens if you set L10N at that UIName="".

@enderseven1 Do you have a screenshot of the bug you described?

@MahBoiDeveloper
Copy link
Contributor

Translation works fine for me.

Translated names of games/mods:
image

Options works fine:
image

General CnCNet chat is displayed normal:
image

Yuri's Revenge chat too:
image

@enderseven1
Copy link

enderseven1 commented Dec 1, 2024

I forgot other details.
The bug maybe happens on option panel.
But the bug doesn't happen now, it's good.

I added L10N to G13s.cs earlier 4 months than this pr.
maybe it doesn't happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants