-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement command-line parameters and environment variables as ConfigArgParse interface #96
Comments
Hm.. Needlessly complex? What was the use case you had in mind?
Either way, we definitely still want configuration via environment
variables so that we can use qbatch with environment-modules.
|
Just kinda worried about the proliferation of environment variables. I'm just thinking about how to handle all cases of defaults for the "I don't want to type this every day" type |
If we ever do consider it https://docs.python.org/2/library/configparser.html |
As an alternative to "environment-variables" support, we could do what pydpiper does, which is define a "default" config file via an ENV var. This would reduce the env var set to one. |
And so in the environment-modules file you could do something like:
I'm okay with that. I also don't see a compelling case to change from |
I can see a case for allowing 'most' of our command line arguments to have settable defaults. This presents an explosion of environment variables. If future options come this could continue. A config file would collapse all these info one, and allow for documentation of options inside the config file. |
Right, I see what you mean. I'm weirdly attached to the convenience of |
It'll be a fairly big piece of work to transform all our options to configparser so I'll stick a "sometime" on this. |
Looks like ConfigArgParse is ideal. Mostly drop-in replacement for ArgParse, with config file and environment variable features in one set: |
Right now we allow defaults via the environment.
@andrewjankie makes a passing mention of config file defaults
The text was updated successfully, but these errors were encountered: