Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPS-1054] Withdraw full Eth coins balance #23

Merged
merged 1 commit into from
Jun 16, 2022
Merged

[UPS-1054] Withdraw full Eth coins balance #23

merged 1 commit into from
Jun 16, 2022

Conversation

cornixxx
Copy link
Contributor

pullrequest[bot]
pullrequest bot reviewed Apr 25, 2022
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.

Check the status or cancel PullRequest code review here.

pullrequest[bot]
pullrequest bot reviewed Apr 25, 2022
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 29
- 13

55% JavaScript
45% JavaScript (tests)

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

pullrequest[bot]
pullrequest bot reviewed Apr 25, 2022
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains important changes related to handling gas related to transactions around withdrawing full Eth balance. This includes code changes as well as corresponding updates to test covereagr. Updated changes all look clean and should be safe to merge.

Image of Adam G Adam G

Was this helpful? Yes | No

Reviewers will be notified any time you reply to their comments or commit new changes.
You can also request a full follow-up review from your PullRequest dashboard.

pullrequest[bot]
pullrequest bot reviewed May 9, 2022
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard.

@Alexey1100 Alexey1100 merged commit 0079530 into main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pullrequest pullrequest[bot] pullrequest[bot] left review comments

@Alexey1100 Alexey1100 Alexey1100 approved these changes

@makarychev makarychev Awaiting requested review from makarychev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cornixxx @Alexey1100