Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRD-2006] Migration to Alchemy #31

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[PRD-2006] Migration to Alchemy #31

merged 2 commits into from
Sep 19, 2023

Conversation

makarychev
Copy link
Collaborator

  1. Infura replaced by Alchemy for EVM blochchains
  2. Removed deprecated blockchain networks: Ropsten and Rinkeby

@linear
Copy link

linear bot commented Sep 7, 2023

PRD-2006 Robowallet / Infura migration

pullrequest[bot]
pullrequest bot reviewed Sep 7, 2023
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This pull request was not sent to the PullRequest network because the pull request is a draft.

@makarychev makarychev marked this pull request as ready for review September 7, 2023 08:03
pullrequest[bot]
pullrequest bot reviewed Sep 7, 2023
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.

Check the status or cancel PullRequest code review here.

pullrequest[bot]
pullrequest bot reviewed Sep 7, 2023
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 56
- 67

72% JavaScript (tests)
19% JavaScript
7% JSON
3% Shell

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

pullrequest[bot]
pullrequest bot reviewed Sep 7, 2023
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look good. There is one issue with renaming a value to the constructor that I think leads to some confusion regarding data security.

Image of David K David K

Reviewed with ❤️ by PullRequest

tests/EthereumBlockchain.getEthBalance.test.js Outdated Show resolved Hide resolved
pullrequest[bot]
pullrequest bot reviewed Sep 7, 2023
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes from the previous review look good, nice to see the change in the value of the key.

Image of David K David K

Reviewed with ❤️ by PullRequest

@Alexey1100 Alexey1100 merged commit c854512 into main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexey1100 Alexey1100 Alexey1100 approved these changes

@cornixxx cornixxx cornixxx approved these changes

@pullrequest pullrequest[bot] pullrequest[bot] approved these changes

@yan-man yan-man yan-man approved these changes

@faruksakic faruksakic faruksakic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@makarychev @Alexey1100 @cornixxx @yan-man @faruksakic