New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init ra build #2

Merged

douglas-f merged 37 commits into main from init-ra-build

Oct 3, 2023

Member

kourosh-forti-hands commented Sep 28, 2023

No description provided.

kourosh-forti-hands added 6 commits

September 25, 2023 15:33


          some initial RA work

7c89069


          initial RA work - got security core and account setup done - doing or…

4e1d1bc

…gs next :)


          initial RA work - got security core and account setup done - doing or…

de23a5f

…gs next :)


          everything until orgs has been deployed - fighting orgs right now

376bb37


          finally fixed org creation things for config, guardduty, sechub - add…

507a173

…ed functionality for account onboarding- will test in the AM


          added accounts to org, org is semi broke due to 3rd account - aws sup…

11bf518

…port case open.

networking deployed - mgmt VPC, and AWS NFW. Will do app ones and TGW when app all accounts get org joined.

can't deploy packer yet bc ```PendingVerification: Your request for accessing resources in this region is being validated, and you will not be able to launch additional resources in this region until the validation is complete. We will notify you by email once your request has been validated. While normally resolved within minutes, please allow up to 4 hours for this process to complete. If the issue still persists, then open a support case. [https://support.console.aws.amazon.com/support/home?region=us-east-1#/case/create?issueType=customer-service&serviceCode=account-management&categoryCode=account-verification]
```
AWS case open

kourosh-forti-hands requested review from mscribellito, ksnavely-cf, cstano, olegkharytonenko-cf and douglas-f

September 28, 2023 21:07


          fixed workflows - i totally never did a find and replace at some poin…

1bb2a39

…t. I blame the git gnomes

github-actions bot commented Sep 29, 2023

Markdown Valid


          wrapped up org implementations

04fe6a0

github-actions bot commented Sep 29, 2023

Markdown Valid


          RDS RA deploy

e3eff65

github-actions bot commented Sep 30, 2023

Markdown Valid


          Packer code included

ce71087

github-actions bot commented Oct 2, 2023

Markdown Valid

ksnavely-cf requested changes

View reviewed changes

Contributor

ksnavely-cf left a comment •

edited

Loading

Comments in line. Where is the documentation for a client trying to apply this? Will it be in a readme or external documentation? Ansible stuff will not be included in initial release. Remove. If packer relies on ansible dir, we need to discuss removing packer from this version.

aws/terraform/us-gov-west-1/global-vars.tf Outdated Show resolved Hide resolved

aws/terraform/us-gov-west-1/management-account/day0/README.md Outdated Show resolved Hide resolved

aws/terraform/us-gov-west-1/management-account/day0/data.tf Outdated Show resolved Hide resolved

aws/terraform/us-gov-west-1/management-account/day0/outputs.tf Outdated Show resolved Hide resolved

aws/terraform/us-gov-west-1/management-account/day0/outputs.tf Show resolved Hide resolved

aws/terraform/us-gov-west-1/networking/test.rules.json Outdated Show resolved Hide resolved

aws/terraform/us-gov-west-1/networking/vars.tfvars Outdated Show resolved Hide resolved

aws/terraform/us-gov-west-1/networking/vars.tfvars Show resolved Hide resolved

aws/terraform/us-gov-west-1/org-onboarding/data.tf Outdated Show resolved Hide resolved

aws/terraform/us-gov-west-1/org-onboarding/vars.tfvars Outdated Show resolved Hide resolved

ksnavely-cf reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved


          updated readme and addressed some comments

58a1a03

github-actions bot commented Oct 2, 2023

Markdown Valid


          updated readme

0d6e923

github-actions bot commented Oct 2, 2023

Markdown Valid

olegkharytonenko-cf added 2 commits

October 2, 2023 13:20


          updated readme

45b1b83


          updated readme

b1fdeb9

github-actions bot commented Oct 2, 2023

Markdown Valid

1 similar comment

github-actions bot commented Oct 2, 2023

Markdown Valid


          updated readme

4d0a8f0


          updated readme

bc87c1e

github-actions bot commented Oct 3, 2023

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

github-actions bot commented Oct 3, 2023

Markdown Valid

github-actions bot commented Oct 3, 2023

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

harrison-dottery-cf and others added 3 commits

October 3, 2023 11:57


          initial-upload

1aac15f


          Merge branch 'init-ra-build' into ReadMe's-Review

a0a0742


          Merge pull request #4 from Coalfire-CF/ReadMe's-Review

f746ee7

initial-upload

github-actions bot commented Oct 3, 2023

Markdown Valid

github-actions bot commented Oct 3, 2023

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

harrison-dottery-cf and others added 4 commits

October 3, 2023 12:30


          networking readMe

083b363


          test

a22afa7


          Merge branch 'init-ra-build' into ReadMe's-Review

7ecb6d4


          Merge pull request #5 from Coalfire-CF/ReadMe's-Review

dd064df

Read me's review

github-actions bot commented Oct 3, 2023

Markdown Valid

github-actions bot commented Oct 3, 2023

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟


          addressing README.md examples of networking

e2fa129

github-actions bot commented Oct 3, 2023

Markdown Valid

github-actions bot commented Oct 3, 2023

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟


          addressing README.md examples of networking

13d2ac8

github-actions bot commented Oct 3, 2023

Markdown Valid

github-actions bot commented Oct 3, 2023

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

kourosh-forti-hands added 4 commits

October 3, 2023 12:58


          Merge branch 'init-ra-build' into sanitization-branch

f601e5f


          sanitization of content

01329c1


          sanitization of content

0c38c2a


          sanitization of content and updating of READMEs

89db8dc

github-actions bot commented Oct 3, 2023

Markdown Valid

github-actions bot commented Oct 3, 2023

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

douglas-f approved these changes

View reviewed changes

douglas-f merged commit 0ed342a into main

9 checks passed

douglas-f deleted the init-ra-build branch

October 3, 2023 18:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ksnavely-cf ksnavely-cf requested changes

douglas-f douglas-f approved these changes

mscribellito Awaiting requested review from mscribellito

cstano Awaiting requested review from cstano

olegkharytonenko-cf Awaiting requested review from olegkharytonenko-cf

Labels

None yet