Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Drag and drop #817

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Conversation

andronov-alexey
Copy link
Contributor

Introduces the issue: during drag there's a lot of messages in debug console from Qt library:

QPixmap::scaled: Pixmap is a null pixmap

That's because we didn't specify the draggable preview for QDrag object.
I couldn't figure out the suitable image :)

Resolves #707

@mlangkabel
Copy link
Contributor

I've tested this change on Windows. Looking great! But I don't get the debug log message from Qt. What operating system are you using?

@andronov-alexey
Copy link
Contributor Author

andronov-alexey commented Dec 2, 2019

I'm using win10 and it happens when I'm dragging text over selection
sourcetrail warning 2 0

Copy link
Contributor

@egraether egraether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this! I don't get any QPixmap related warnings on macOS, but maybe you can fix them by setting an empty QPixmap. Please take a look at my comments.

src/lib_gui/qt/element/code/QtCodeArea.cpp Outdated Show resolved Hide resolved
src/lib_gui/qt/element/code/QtCodeArea.cpp Outdated Show resolved Hide resolved
- pasting available in external targets like text editors, IDE's, etc.
@andronov-alexey
Copy link
Contributor Author

maybe you can fix them by setting an empty QPixmap

Tried this to no avail :) I suggest to just ignore this warning

@egraether egraether merged commit 136f3b5 into CoatiSoftware:master Dec 2, 2019
@egraether
Copy link
Contributor

Thank you!
For the future: Please use an additional commit to address review changes. We use "squash and merge" policy for pull requests, so all commits on your branch will be merged into one.

@andronov-alexey andronov-alexey deleted the drag_and_drop branch December 5, 2019 13:02
egraether pushed a commit that referenced this pull request Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag & drop selected source code from Sourcetrail into other application/editor
3 participants