This repository has been archived by the owner on Nov 3, 2020. It is now read-only.
Add CPPodfileConsoleTextView to allow auto scrolling #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188 by adding
CPPodfileConsoleTextView
to allow the text view to automatically scroll to the bottom if it was previously there.I attempted to do this scrolling via utilizing
NSTextView
delegate methods onCPPodfileConsoleViewController
but none of them had the right order of completion. We must check current position, then append text and then scroll for this action to function correctly.To do this, I have added an
attributedText
property to theCPPodfileConsoleTextView
subclass (couldn't overrideattributedString
directly). OndidSet
we check the current position then swap out the actualattributedString
on the text storage and scroll to the previous positioning.There may be a simpler way to do this than subclassing and adding a property but I couldn't work it out. If anyone has a suggestion on a cleaner way to implement this, I'm happy to give it a shot.