-
Notifications
You must be signed in to change notification settings - Fork 283
[Podfile Editor] Allow option clicking on a pod #333
Conversation
awesome, glad to see it ( might be worth a rebase ) will give it a real look tomorrow 👯 |
Is there a way we can do this without associated objects? Not sure for OS X, but they're a pretty bad idea to rely on in iOS. What if we subclassed or extended |
@nwest What I'm currently doing is extending the |
return (podName, podNameRange) | ||
} | ||
|
||
private func updateUnderlineStyle(forPodAtRange range: NSRange) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice touch with forPodAtRange
Alright, yeah, I'm happy with that explanation - I should fix the danger CI issue - but that's not a blocker here 👍 |
Ah, it has merge conflicts - good to go after that's handled |
# Conflicts: # app/CocoaPods.xcodeproj/project.pbxproj
@orta fixed conflicts 💪 |
awesome - thanks |
Given this a run through - looks and feels great, good job @pedrovieira7 |
This PR implements #302 - "Allow option clicking on a pod":
WebView
will redirect the user to the browserWebView
How it looks:
Would love to get some feedback.