Added option to remove Command-Line Tool again (#338) #344
Conversation
moved creation of CLIToolInstallationController to init of CPHomeWindowController (was in windowDidLoad)
Generated by 🚫 danger |
| @@ -43,5 +48,7 @@ extern NSString * const kCPCLIToolInstalledToDestinationsKey; | |||
|
|
|||
| - (BOOL)binstubAlreadyExists; | |||
|
|
|||
| /// Returns `YES` if binstub was installed using this controller. | |||
| - (BOOL)hasInstalledBinstubBefore; | |||
|
I finally had time to investigate how to remove a file from privileged location. I opted for AppleScript as it seems for me the easiest solution right now. Other solution would involve creating privileged helper tool with proper signing and installation. And I think its not worth the effort right now for this feature ;) |
|
@orta any idea why travis-ci failed on my? I don't see any error messages except warnings which are not in my code. and this
which I don't know what that means ;) |
|
I do not, though I do not believe it should delay a review of the code, and if you're happy with merging it's fine by me, the CI only tests the command line integration, not any of the GUI. |
|
|
||
| return NO; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is all really well documented, thanks!
|
Cool, I'm going to give this CI a second chance to green, and merge at the end of it 👍 |
|
Alright, 👍 |
|
yeah, thx 👍 :) |
Finally i had some time to put this together. This is my first commit ever for an mac app, so I have no idea if its correct ;-)
And I have no idea about the privileged access to remove the binstub how to do it ;)(Solved)