Improved warning message for DSL attribute renaming

CocoaPods · May 17, 2016 · ed1aaa7 · ed1aaa7
1 parent 5374c41
commit ed1aaa7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,7 +4,9 @@
 
 ##### Enhancements
 
-* None.  
+* Improved warning message for the renaming of `xcodeproj` to `project` in the `Podfile` DSL.  
+  [Olivier Halligon](https://github.com/AliSoftware)
+  [#?](https://github.com/CocoaPods/CocoaPods/pull/?)
 
 ##### Bug Fixes
 

diff --git a/lib/cocoapods-core/podfile/dsl.rb b/lib/cocoapods-core/podfile/dsl.rb
@@ -513,7 +513,7 @@ def project(path, build_configurations = {})
       # For pre-1.0 versions use `xcodeproj`.
       #
       def xcodeproj(*args)
-        CoreUI.warn 'xcodeproj was renamed to `project`. Please use that from now on.'
+        CoreUI.warn '`xcodeproj` was renamed to `project`. Please update your Podfile accordingly.'
         project(*args)
       end
 

diff --git a/spec/podfile/dsl_spec.rb b/spec/podfile/dsl_spec.rb
@@ -481,7 +481,7 @@ module Pod
         podfile = Podfile.new { xcodeproj 'App.xcodeproj', 'Test' => :debug }
         podfile.target_definitions['Pods'].user_project_path.should == 'App.xcodeproj'
         podfile.target_definitions['Pods'].build_configurations.should == { 'Test' => :debug }
-        CoreUI.warnings.should == 'xcodeproj was renamed to `project`. Please use that from now on.'
+        CoreUI.warnings.should == '`xcodeproj` was renamed to `project`. Please update your Podfile accordingly.'
       end
     end