Cache target definition label value

CocoaPods · Jun 20, 2017 · f5b34bc · f5b34bc
1 parent f085263
commit f5b34bc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -25,6 +25,10 @@
 
 ##### Bug Fixes
 
+* Cache target definition label value  
+  [Dimitris Koutsogiorgas](https://github.com/dnkoutso)
+  [#387](https://github.com/CocoaPods/Core/pull/387)
+
 * Cache version result for each pod and segments  
   [Dimitris Koutsogiorgas](https://github.com/dnkoutso)
   [#385](https://github.com/CocoaPods/Core/pull/385)

diff --git a/lib/cocoapods-core/podfile/target_definition.rb b/lib/cocoapods-core/podfile/target_definition.rb
@@ -23,6 +23,7 @@ def initialize(name, parent, internal_hash = nil)
         @internal_hash = internal_hash || {}
         @parent = parent
         @children = []
+        @label = nil
         self.name ||= name
         if parent.is_a?(TargetDefinition)
           parent.children << self
@@ -106,13 +107,13 @@ def empty?
       #         name.
       #
       def label
-        if root? && name == 'Pods'
-          'Pods'
-        elsif exclusive? || parent.nil?
-          "Pods-#{name}"
-        else
-          "#{parent.label}-#{name}"
-        end
+        @label ||= if root? && name == 'Pods'
+                     'Pods'
+                   elsif exclusive? || parent.nil?
+                     "Pods-#{name}"
+                   else
+                     "#{parent.label}-#{name}"
+                   end
       end
 
       alias_method :to_s, :label
@@ -145,6 +146,7 @@ def name
       # @return [void]
       #
       def name=(name)
+        @label = nil
         set_hash_value('name', name)
       end