Add labels to all the linter warnings and errors #122
Conversation
| @@ -50,7 +50,7 @@ def lint | |||
| run_root_validation_hooks | |||
| perform_all_specs_analysis | |||
| else | |||
| error "The specification defined in `#{file}` could not be loaded." \ | |||
| error "[Spec] The specification defined in `#{file}` could not be loaded." \ | |||
|
Why not then create a new method that takes an error category and message and can then sort the errors by category (and ultimately line number)? |
|
@segiddins that might be a better approach, the line number isn't the responsibility of the linter backend, but I can see how this could work. There needs to be a refactor of the results class (on my todo list) as well, but I figured this would be a quick way to make things a tad easier. |
|
Also it appears @houndci hates me too... |
|
@kapin gotcha. Haven't yet spent too much time with the linter |
|
This is definitely headed in the direction I think is good. One thing. Can the text inside the brackets directly specify the attribute? For example. Sources would be source and weak frameworks would be weak_frameworks |
|
@Keithbsmiley definitely can do that. |
|
Also github sources. And whatever else you need to do for line numbers. 😃 |
|
@Keithbsmiley, let me give some though on the line numbers, it may require more of a dig into spec DSL to parse the line number when we read in the podspec. |
|
If it would be parsing and not tracking as they were loaded I think it would make sense to expose that from something like a |
| @@ -50,7 +50,7 @@ def lint | |||
| run_root_validation_hooks | |||
| perform_all_specs_analysis | |||
| else | |||
| error "The specification defined in `#{file}` could not be loaded." \ | |||
| error "[spec] The specification defined in `#{file}` could not be loaded." \ | |||
|
Ace work! |
| @@ -50,7 +50,8 @@ def lint | |||
| run_root_validation_hooks | |||
| perform_all_specs_analysis | |||
| else | |||
| error "The specification defined in `#{file}` could not be loaded." \ | |||
| error "[spec] The specification defined in `#{file}` could not be" \ | |||
| " loaded." \ | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Every warning and error should now begin with [CATEGORY]. Updated a bunch of tests as well to check that these are included.
|
Awesome work... this can be merged after the changelog entry is added! |
|
FYI to fix rubocopo/houndci issues you can run |
|
Added so merging 😺 |
Add labels to all the linter warnings and errors
|
🌠 |
|
Damn nice, @kapin! |
Add labels to all the linter warnings and errors
Every warning and error should now begin with [CATEGORY]. Updated a
bunch of tests as well to check that these are included.
Still a bit of a WIP, but this should make @Keithbsmiley a bit happier.