Give Sources and SourceProviders a url attribute

[segiddins]

This is needed for CocoaPods/CocoaPods#2513.

[k0nserv]

Maybe we should use # rubocop:disable Style/SpecialGlobalVars for the relevant line instead. This would allow the check to stay in place or the rest of the code which is preferable.

[segiddins]

That decision is left up to @alloy and @fabiopelosin

[k0nserv]

It feels a bit like an overreach to disable it globally for one infraction that's my only concern with it

[fabiopelosin]

As long as we support Ruby 1.8.7 we are completely disabling it (because adding a comment to each line with $? would be inconvenient and style checks should not be inconvenient).

[alloy]

I don’t know if this config entry is about anything other than the use of the ‘English’ lib. If it’s only about that, then we can disable it globally, otherwise disabling it for just that line makes sense.

[alloy]

As long as we support Ruby 1.8.7

@fabiopelosin Interesting. Are you saying that Ruby 2 has the English variants by default?

[fabiopelosin]

They can be required: CocoaPods/cocoapods-downloader@b2128b1

[alloy]

Oh I see, they’re simply not available at all on 1.8. Gotcha 👍

[fabiopelosin]

The GHDataProvider is not being currently used and can be removed. I implemented it because at the time I was of the opinion (and to a certain extent I still do) that using git to download the master repo will lead to performance issues as the repo grows in size.

However supporting multiple strategies for the sources has drawbacks, one among them is that a strategy based on the GitHub APIs would not be easily adaptable to the awesome evaluations that lead to this patch. Being life a matter of choosing among trade-offs, now I think that the GHDataProvider
should be removed.

[alloy]

Being life a matter of choosing among trade-offs, now I think that the GHDataProvider
should be removed.

❤️ 👍

(And it’s still in the commit history when we do decide otherwise.)

[segiddins]

We can always add it back if we change our minds.

-Samuel E. Giddins

On Sep 25, 2014, at 3:47 AM, Eloy Durán notifications@github.com wrote:

Being life a matter of choosing among trade-offs, now I think that the GHDataProvider
should be removed.

—
Reply to this email directly or view it on GitHub.=