[Linter] Cleanup the github sources checks #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code climate hates this function so I pulled it apart a little bit. Also since you can't have a gist that starts with `www.`, added a check for that as well.
| @@ -377,8 +380,6 @@ def _validate_social_media_url(s) | |||
|
|
|||
| # @!group All specs validation helpers | |||
|
|
|||
| private | |||
There was a problem hiding this comment.
There is already a private label higher up in the file. I can add it back if we want it for consistencies sake.
| def perform_github_uri_checks(git, git_uri) | ||
| if git_uri.host.start_with?('www.') | ||
| results.add_warning('github_sources', 'Github repositories should ' \ | ||
| 'not use `www` in their URL.') |
There was a problem hiding this comment.
second line of the method call should be indented 2 spaces
segiddins
added a commit
that referenced
this pull request
Nov 28, 2014
[Linter] Cleanup the github sources checks
Ashton-W
pushed a commit
to Ashton-W/Core
that referenced
this pull request
Nov 2, 2015
[Linter] Cleanup the github sources checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code climate hates this function so I pulled it apart a little bit. Also since you can't have a gist that starts with
www., added a check forthat as well. Related to #48 as this is another small improvement to the linter.