Added module_name attribute.
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,10 @@ | |||
|
|
|||
| ##### Enhancements | |||
|
|
|||
| * Added `module_name` attribute for use with frameworks. | |||
| [Boris Bügling](https://github.com/neonichu) | |||
| [Core#204](https://github.com/CocoaPods/Core/issues/205) | |||
2 tasks
15 tasks
|
|
||
| it 'should mask invalid chars' do | ||
| @spec.send(:c99ext_identifier, 'iOS-App BânánàLïb').should == 'iOS_App_B_n_n_L_b' | ||
| end |
| end | ||
|
|
||
| it 'should mask invalid chars' do | ||
| @spec.send(:c99ext_identifier, 'iOS-App BânánàLïb').should == 'iOS_App_B_n_n_L_b' |
There was a problem hiding this comment.
Should characters with accents instead be mapped to those without accents? Eloy's name is not built up of invalid characters.
á should be shown as a instead of _?
There was a problem hiding this comment.
Indeed, was changed in f65331b
mrackwitz
added a commit
that referenced
this pull request
Dec 7, 2014
Added `module_name` attribute.
Ashton-W
pushed a commit
to Ashton-W/Core
that referenced
this pull request
Nov 2, 2015
Added `module_name` attribute.
|
Changes Unknown when pulling ed492e9 on module-name-attribute into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #205