Fail if a spec is deprecated_in_favor_of itself #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Performs validations related to the `deprecated_in_favor_of` attribute. | ||
| # | ||
| def _validate_deprecated_in_favor_of(d) | ||
| if d == @spec.name |
|
Changelog entry? |
|
lol Btw, that extra whitespace in the CHANGELOG should stay, it’s there to ensure proper formatting on GH. |
keith
force-pushed
the
ks-deprecated
branch
2 times, most recently
from
d04cb32 to
c1e4bff
Compare
| * The Linter will now ensure against marking a spec as | ||
| `deprecated_in_favor_of` itself. | ||
| [Keith Smiley](https://github.com/Keithbsmiley) | ||
| [#212](https://github.com/CocoaPods/Core/pull/212) |
There was a problem hiding this comment.
Please reference the original issue, not this PR
There was a problem hiding this comment.
That spec PR really isn't an original issue. Also that is linked from here.
|
|
segiddins
added a commit
that referenced
this pull request
Dec 23, 2014
Fail if a spec is deprecated_in_favor_of itself
Ashton-W
pushed a commit
to Ashton-W/Core
that referenced
this pull request
Nov 2, 2015
Fail if a spec is deprecated_in_favor_of itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may seem funny. If so, see CocoaPods/Specs#12876