[Source] Make #search case sensistive even on case-insensitive HFS+ #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -201,7 +201,8 @@ def search(query) | |||
| if query.is_a?(Dependency) | |||
| query = query.root_name | |||
| end | |||
| if (specs_dir + query).directory? | |||
| spec_dir = specs_dir + query | |||
| if Pathname.glob(spec_dir) == [spec_dir] | |||
There was a problem hiding this comment.
We should escape this path given to glob, since it could contain characters causing it to break. See CocoaPods/CocoaPods@f4df7a6
There was a problem hiding this comment.
I don't think we need to, as there are no valid spec names that contain glob characters
|
Maybe the find module can be of help? |
|
@alloy how so? |
|
Maybe it ends up being a faster way to implement the search/Pathname.glob (of which we have our own implementation iirc?), which is what you were mentioning. |
…he need to escape glob patterns
|
This has been updated to no longer use a glob. |
|
|
segiddins
added a commit
that referenced
this pull request
Apr 27, 2015
[Source] Make #search case sensistive even on case-insensitive HFS+
Ashton-W
pushed a commit
to Ashton-W/Core
that referenced
this pull request
Nov 2, 2015
…tive [Source] Make #search case sensistive even on case-insensitive HFS+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd love to do this in a faster way, and in a manner that doesn't rely on
Pathname.glob's results matching the underlying preserved case.\c @kylef @samdmarshall
Closes CocoaPods/CocoaPods#3024.
Closes CocoaPods/CocoaPods#2910.